Skip to content

Commit

Permalink
update velocity_limit docstring and clean up test_articulation
Browse files Browse the repository at this point in the history
  • Loading branch information
jtigue-bdai committed Jan 9, 2025
1 parent 4ab503a commit c7fef1e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@ class ActuatorBaseCfg:
"""Velocity limit of the joints in the group. Defaults to None.
This limit is used by the actuator model. If None, the limit is set to the value specified in the USD joint prim.
.. note::
velocity_limit is not used in ActuatorBaseCfg but is provided for inherited version like
:class:`omni.isaac.lab.actuators.DCMotor`.
"""

effort_limit_sim: dict[str, float] | float | None = None
Expand All @@ -55,6 +60,7 @@ class ActuatorBaseCfg:
If None, the limit is set to the value specified in the USD joint prim. Resulting solver solutions will constrain
velocities by these limits. If velocity limits are too tight issues with solver convergence may occur.
"""

stiffness: dict[str, float] | float | None = MISSING
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ def generate_articulation_cfg(
articulation_type: Literal["humanoid", "panda", "anymal", "shadow_hand", "single_joint"],
stiffness: float | None = 10.0,
damping: float | None = 2.0,
vel_limit: float | None = 100.0,
effort_limit: float | None = 400.0,
vel_limit_sim: float | None = None,
effort_limit_sim: float | None = None,
) -> ArticulationCfg:
Expand Down Expand Up @@ -77,8 +75,6 @@ def generate_articulation_cfg(
actuators={
"joint": ImplicitActuatorCfg(
joint_names_expr=[".*"],
effort_limit=effort_limit,
velocity_limit=vel_limit,
effort_limit_sim=effort_limit_sim,
velocity_limit_sim=vel_limit_sim,
stiffness=0.0,
Expand Down

0 comments on commit c7fef1e

Please sign in to comment.