fix: doctype with entities handling #272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #272 Credit: @SethFalco Close: #272 Reviewed-by: @isaacs
isaacs
force-pushed
the
fix/doctype-entities
branch
from
c54e3ab
to
968b53c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing comments in DTDs I introduced an issue by mistake where the
ondoctypeevent would no longer fire for DOCTYPEs anymore.DOCTYPE_DTD, append the current character if we're not changing state.SGML_DECL, if we've established it's not a comment, and we know we're in a DOCTYPE declaration, change the state back toDOCTYPE_DTDand add the characters encountered so far.This retains the ability to handle comments, but brings back the handling/event for DOCTYPEs declaration like entities.
I've added more tests for DOCTYPE declarations to make sure this isn't missed in future.
Related