set type:module in package.json only if main is not cjs

isaacs · Sep 26, 2023 · 56e018c · 56e018c
1 parent d460568
commit 56e018c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/exports.ts b/src/exports.ts
@@ -107,9 +107,12 @@ export const setMain = (
     }
     const types = resolveExport(pkg.exports['.'], [m, 'types'])
     pkg.main = mod
+    if (c.main === 'esm') pkg.type = 'module'
+    else delete pkg.type
     if (types && types !== mod) pkg.types = types
     else delete pkg.types
   } else {
+    pkg.type = 'module'
     delete pkg.main
     delete pkg.types
   }

diff --git a/test/exports.ts b/test/exports.ts
@@ -74,10 +74,12 @@ t.test('setting top level main', async t => {
       exports: Record<string, Export>
       main?: string
       types?: string
+      type?: string
     },
     {
       main?: string
       types?: string
+      type?: string
     },
     boolean
   ][] = [
@@ -91,7 +93,7 @@ t.test('setting top level main', async t => {
           },
         },
       },
-      {},
+      { type: 'module' },
       true,
     ],
     [
@@ -119,7 +121,7 @@ t.test('setting top level main', async t => {
           },
         },
       },
-      { main: './i.js', types: './i.d.ts' },
+      { type: 'module', main: './i.js', types: './i.d.ts' },
       true,
     ],
     [
@@ -147,7 +149,7 @@ t.test('setting top level main', async t => {
           },
         },
       },
-      { main: './i.js' },
+      { main: './i.js', type: 'module' },
       true,
     ],
     [
@@ -241,6 +243,7 @@ t.test('setting top level main', async t => {
       if (ok) {
         t.equal(pkg.main, expect.main)
         t.equal(pkg.types, expect.types)
+        t.equal(pkg.type, expect.type)
       } else {
         t.strictSame(exits(), [[1]])
         t.matchSnapshot(fails)