Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider adding support for module-sync export condition #94

Open
ericallam opened this issue Sep 26, 2024 · 3 comments
Open

consider adding support for module-sync export condition #94

ericallam opened this issue Sep 26, 2024 · 3 comments

Comments

@ericallam
Copy link
Sponsor

nodejs/node#54648

@ericallam ericallam changed the title consider adding support for module-sync consider adding support for module-sync export condition Sep 26, 2024
@isaacs
Copy link
Owner

isaacs commented Sep 26, 2024

So, it looks like, it should point to the ESM version, but that's only safe to do if it doesn't use top level await? Are there other conditions, or a link to the node docs that describe when it's ok to use?

@ericallam
Copy link
Sponsor Author

No Node.js docs out yet, and yes I think you have that correct. It's possible the solution for tshy would just be an option in the tshy config to enable outputting the module-sync export condition, leaving it up to the user to decide.

@isaacs
Copy link
Owner

isaacs commented Sep 26, 2024

I wonder if we could detect it somehow by parsing the built code? It'd be nice to not have this need to be opt-in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants