Added comment to clarify necessity of VS retry policy

istio · Jun 20, 2024 · d6d9440 · d6d9440
1 parent 4e8b763
commit d6d9440
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/networking/v1alpha3/destination_rule.pb.go b/networking/v1alpha3/destination_rule.pb.go
diff --git a/networking/v1alpha3/destination_rule.pb.html b/networking/v1alpha3/destination_rule.pb.html
diff --git a/networking/v1alpha3/destination_rule.proto b/networking/v1alpha3/destination_rule.proto
@@ -647,6 +647,10 @@ message ConnectionPoolSettings {
 
     // The amount of concurrent retries allowed in the case of failure, a
     // percentage of the active requests.
+    //
+    // NOTE: Including a retry budget requires a retry policy to exist within
+    // the [VirtualService](https://istio.io/latest/docs/reference/config/networking/virtual-service/#HTTPRetry) resource
+    // routing to this destination, in order for failed requests to be retried.
     RetryBudget retry_budget = 9;
   };