Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support agression and min_weight_percent in DestinationRule #3215

Closed
frgaudet opened this issue May 23, 2024 · 0 comments · Fixed by #3216
Closed

Support agression and min_weight_percent in DestinationRule #3215

frgaudet opened this issue May 23, 2024 · 0 comments · Fixed by #3216

Comments

@frgaudet
Copy link
Contributor

(This is used to request new product features, please visit https://discuss.istio.io for questions on using Istio)

Describe the feature request
We are using Java micro-services, which usually needs a warmup phase to have the best performance. After testing warmupDurationSecs on production it was not concluant, because of the min_weight_percent that is by default 10%. It is already too much for our service.

Indeed currently DestinationRules only support envoy's slow_start_window :

spec:
  host:app.svc.cluster.local
  trafficPolicy:
    loadBalancer:
      warmupDurationSecs: 2

But the API is lacking aggression and min_weight_percent parameters (cf. envoy doc) which are essentials in our context.

Describe alternatives you've considered

We considered using EnvoyFilter (cf. istio/istio#41039 (comment)); It provides us good technical results but having so much EnvoyFilter to maintain adds a lot of toil.

Affected product area (please put an X in all that apply)

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience

Additional context

This is a feature I'm ok to implement if this is a something the community really wants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants