Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose retry_budget within API DestinationRule ConnectionPoolSettings #3249

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ericdbishop
Copy link
Member

Expose the Envoy CircuitBreaker retry_budget ConnectionPoolSettings within DestinationRule ConnectionPoolSettings HTTP configuration.

Credit to @quraynai as I used #2734 as a reference.

Issue: istio/istio#27419

@ericdbishop ericdbishop requested a review from a team as a code owner July 1, 2024 15:31
@istio-policy-bot
Copy link

😊 Welcome @ericdbishop! This is either your first contribution to the Istio api repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added needs-rebase Indicates a PR needs to be rebased before being merged size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test labels Jul 1, 2024
@istio-testing
Copy link
Collaborator

Hi @ericdbishop. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Jul 1, 2024
@craigbox
Copy link
Contributor

craigbox commented Jul 2, 2024

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jul 2, 2024
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 2, 2024
@ericdbishop
Copy link
Member Author

I provided more context in my PR in the main repo istio/istio#51823

@zirain
Copy link
Member

zirain commented Jul 22, 2024

This was raised up again and again in the past, it's really meaningful.

Even knowing that this conflicts with an long timeexisting feature, I do think DestiontaionRule is the most appropriate place.

@ericdbishop
Copy link
Member Author

@zirain we are discussing in istio/istio#51823 if you'd like to join in the conversation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants