[release-1.23] Allow targetRef to SE #3314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
release-notes-none
Merged
istio-testing
added
the
size/XS
istio-testing
force-pushed
the
cherry-pick-3271-to-release-1.23
branch
from
79d526a
to
fdc37d6
Compare
|
istio/istio#52727 (reply in thread), some users are struggling with this now, so I think it would be good if we can cherry-pick the validation fix and get it into 1.23.2 or .3 depending on timing. |
|
@howardjohn, do you see any reason not to fix this in 1.23? |
linsun
approved these changes
Sep 27, 2024
|
Actually, to my surprise istio/istio#52154 did not make it into 1.23 so it's not as simple as adjusting the validation 😔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #3271