Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alignment of PID Data Model with IA #529

Open
wants to merge 15 commits into
base: versione-corrente
Choose a base branch
from
Open

Alignment of PID Data Model with IA #529

wants to merge 15 commits into from

Conversation

m-basili
Copy link
Collaborator

@m-basili m-basili commented Jan 17, 2025 •
edited
Loading

This PR:

List changes introduced:

Added issuing_authority and issuing_country as mandatory PID/(Q)EAA parameters
Added nbf as optional PID/(Q)EAA parameter
Added birth_place and nationality PID claims
Updated non-normative examples
Added trust_framework in the verification claim
Added metadata claims: trust_frameworks_supported and evidence_supported
Added tax_id_code PID claim

@m-basili m-basili added this to the 0.9.1 milestone Jan 17, 2025
m-basili and others added 2 commits January 20, 2025 10:37
@m-basili @giadas
Update docs/en/pid-eaa-data-model.rst
b37cf48 
Co-authored-by: Giada Sciarretta <giada.sciarretta@gmail.com>
@m-basili
chore: fix build error
f0d52ef
@fmarino-ipzs @peppelinux
Apply suggestions from code review
1612558 
Co-authored-by: Giuseppe De Marco <demarcog83@gmail.com>
m-basili
m-basili commented Jan 22, 2025
View reviewed changes
examples/ec-eaa.json Outdated Show resolved Hide resolved
@m-basili m-basili requested review from giadas and peppelinux January 22, 2025 12:40
peppelinux
peppelinux requested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@peppelinux peppelinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments still requires to be addressed. Overall approved.

m-basili and others added 4 commits January 23, 2025 16:45
@m-basili @peppelinux
Update docs/en/defined-terms.rst
2144cb6 
Co-authored-by: Giuseppe De Marco <demarcog83@gmail.com>
@m-basili @peppelinux
Update docs/en/defined-terms.rst
4c56bfe 
Co-authored-by: Giuseppe De Marco <demarcog83@gmail.com>
@m-basili @peppelinux
Update docs/en/pid-eaa-data-model.rst
1e58925 
Co-authored-by: Giuseppe De Marco <demarcog83@gmail.com>
@m-basili @peppelinux
Update docs/en/pid-eaa-data-model.rst
f8e93f8 
Co-authored-by: Giuseppe De Marco <demarcog83@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppelinux peppelinux peppelinux requested changes

@giadas giadas giadas approved these changes

@grausof grausof grausof approved these changes

@fmarino-ipzs fmarino-ipzs Awaiting requested review from fmarino-ipzs

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
EUDI Wallet IT Technical Specifications
Status: No status
Milestone
0.9.1
5 participants
@m-basili @grausof @peppelinux @giadas @fmarino-ipzs