Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter exposes information earlier. Exclude based on endpoint #534

Merged
merged 1 commit into from
Oct 1, 2022

Conversation

itavero
Copy link
Owner

@itavero itavero commented Sep 30, 2022

Option to exclude based on endpoint relates to #517

Besides that the exposes information is now filtered in the platform accessory, before calling the different service handlers (a.k.a. converters).
This should result in more consistent behavior and less complexity in the service handlers itself.

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 53.44% // Head: 53.44% // No change to project coverage 👍

Coverage data is based on head (3743112) compared to base (d19f77e).
Patch has no changes to coverable lines.

❗ Current head 3743112 differs from pull request most recent head 570e941. Consider uploading reports for the commit 570e941 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #534   +/-   ##
=======================================
  Coverage   53.44%   53.44%           
=======================================
  Files          37       37           
  Lines        2116     2116           
  Branches      541      541           
=======================================
  Hits         1131     1131           
  Misses        513      513           
  Partials      472      472           
Flag Coverage Δ
tests 53.44% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/converters/lock.ts 68.75% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Add option to exclude based on endpoint (relates to #517).
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

62.8% 62.8% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2022

🆗 Published SonarCloud and code coverage data.

@itavero itavero merged commit 79eec06 into master Oct 1, 2022
@itavero itavero deleted the ignore-endpoint branch October 1, 2022 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant