fs: reflink: try to normalize permissions on any platform

iterative · Dec 6, 2023 · e78f817 · e78f817
1 parent 3a2fd37
commit e78f817
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/src/dvc_objects/fs/generic.py b/src/dvc_objects/fs/generic.py
@@ -2,7 +2,6 @@
 import errno
 import logging
 import os
-import sys
 from contextlib import suppress
 from functools import wraps
 from typing import TYPE_CHECKING, Any, Callable, List, Optional, Union
@@ -61,12 +60,8 @@ def _link(
 
     func = getattr(to_fs, link)
     func(from_path, to_path)
-    if (
-        link == "reflink"
-        and sys.platform == "darwin"
-        and isinstance(from_fs, LocalFileSystem)
-    ):
-        # NOTE: reflink on macos also clones src permissions
+    if link == "reflink" and isinstance(from_fs, LocalFileSystem):
+        # NOTE: reflink may or may not clone src permissions
         os.chmod(to_path, 0o666 & ~umask)
 
 

diff --git a/src/dvc_objects/fs/utils.py b/src/dvc_objects/fs/utils.py
@@ -191,9 +191,8 @@ def copyfile(
 
     try:
         system.reflink(src, dest)
-        if sys.platform == "darwin":
-            # NOTE: reflink on macos also clones src permissions
-            os.chmod(dest, 0o666 & ~umask)
+        # NOTE: reflink may or may not clone src permissions
+        os.chmod(dest, 0o666 & ~umask)
         return
     except OSError:
         pass