Skip to content

Commit

Permalink
deps: get rid of pylint-pytest, bump pylint, silence warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
dtrifiro committed Jan 12, 2023
1 parent 235122b commit 0fd0736
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
8 changes: 6 additions & 2 deletions dvc_ssh/tests/fixtures.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# pylint: disable=redefined-outer-name

import os

import pytest
Expand All @@ -6,12 +8,14 @@


@pytest.fixture(scope="session")
def docker_compose_file(pytestconfig):
def docker_compose_file(pytestconfig): # pylint: disable=unused-argument
return os.path.join(os.path.dirname(__file__), "docker-compose.yml")


@pytest.fixture(scope="session")
def ssh_server(docker_compose, docker_services):
def ssh_server( # pylint: disable=unused-argument
docker_compose, docker_services
):
import asyncssh
from sshfs import SSHFileSystem

Expand Down
5 changes: 2 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,11 @@ files = ["dvc_ssh"]
[tool.pylint.master]
extension-pkg-whitelist = ["pygit2"]
init-hook = "import sys; sys.path.append(str('tests'))"
load-plugins = ["pylint_pytest"]

[tool.pylint.message_control]
disable = [
"format", "refactoring", "spelling", "design", "no-self-use",
"invalid-name", "misplaced-comparison-constant", "duplicate-code", "fixme",
"format", "refactoring", "spelling", "design",
"invalid-name", "duplicate-code", "fixme",
"unused-wildcard-import", "cyclic-import", "wrong-import-order",
"wrong-import-position", "ungrouped-imports", "multiple-imports",
"logging-format-interpolation", "logging-fstring-interpolation",
Expand Down
4 changes: 1 addition & 3 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,7 @@ tests =
collective.checkdocs==0.2
pydocstyle==6.1.1
# pylint requirements
pylint==2.11.1
# we use this to suppress pytest-related false positives in our tests.
pylint-pytest==1.1.2
pylint==2.15.9
# we use this to suppress some messages in tests, eg: foo/bar naming,
# and, protected method calls in our tests
pylint-plugin-utils==0.6
Expand Down

0 comments on commit 0fd0736

Please sign in to comment.