Skip to content

Commit

Permalink
fix test_daemon.py::test_analytics flakiness
Browse files Browse the repository at this point in the history
Turns out `iterative-telemetry` spends a long time trying to
generate an id. Sometimes it gets frozen for a long time (>30s).
  • Loading branch information
skshetry committed Aug 14, 2024
1 parent b9bcb45 commit b1afac7
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion tests/func/test_daemon.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,10 @@ def test_analytics(tmp_path, server):
}
env.pop("DVC_TEST", None)
env.pop("DVC_NO_ANALYTICS", None)
# The `iterative-telemetry` package calls `gh api` to generate a CI id.
# This might hang, possibly due to load on machine due to other tests running.
# Removing the GITHUB_ACTIONS env var avoids calling `gh api`.
env.pop("GITHUB_ACTIONS", None)

output = subprocess.check_output(
[*_get_dvc_args(), "config", "-l", "-vv"],
Expand All @@ -113,7 +117,7 @@ def test_analytics(tmp_path, server):
pid = int(match.group(1).strip())

with suppress(psutil.NoSuchProcess):
psutil.Process(pid).wait(timeout=30)
psutil.Process(pid).wait(timeout=10)

log_contents = logfile.read_text(encoding="utf8")
expected_line = (f"Process {pid} " if os.name != "nt" else "") + "exiting with 0"
Expand Down

0 comments on commit b1afac7

Please sign in to comment.