Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependency/repo: do not suppress OSError on info() #10533

Merged
merged 1 commit into from
Aug 20, 2024
Merged

dependency/repo: do not suppress OSError on info() #10533

merged 1 commit into from
Aug 20, 2024

Conversation

skshetry
Copy link
Member

No description provided.

@skshetry skshetry mentioned this pull request Aug 20, 2024
Merged
dberenbaum
dberenbaum approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@dberenbaum dberenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I was more curious rather than recommending you drop it. I'm fine either way. We shouldn't hit OSError, but no strong opinion on whether it's better to fail or keep going if it happens.

@skshetry
Copy link
Member Author

skshetry commented Aug 20, 2024 •
edited
Loading

I think it's okay to fail here on OSError. It's going to fail anyway on save_outs() later if it failed here.
Or, If it failed on DVCFileSystem.info(), that is likely a bug.

@skshetry skshetry merged commit 2dcaea8 into main Aug 20, 2024
26 checks passed
@skshetry skshetry deleted the skshetry-patch-1 branch August 20, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dberenbaum dberenbaum dberenbaum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skshetry @dberenbaum