dvc-10427 Always Clean the Workers on Shutdown. #10552
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to effectively remove the obsolete files in `FSApp.data_folder_in` we need to call `clean` for each worker. This should be a fairly safe operation as `_gc` will exclude from cleaning non expired messages. Check sibling PR on `dvc-task` for clarifications.
nablabits
changed the title
|
After the discussion here, this PR is not anymore needed so I will close it —unless anyone sees value in the tests I wrote— |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
In order to effectively remove the obsolete files in
FSApp.data_folder_in(source) we need to callcleanfor each worker. This should be a fairly safe operation as_gc(source) will exclude from cleaning non expired messages.How to Test this
It's somewhat tricky to set up everything to verify the solution, so I have created a PR here to ease the process:
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏