fix: directory creation on pulling data

[sssilvar]

Closes #10579

[skshetry]

There is no exist_ok=True in os.mkdir. That is in os.makedirs.

This should either be:

Suggested change

	os.mkdir(d, exist_ok=True)
	try:
	os.mkdir(d)
	except OSError:
	if not os.path.isdir(d):
	raise

or,

Suggested change

	os.mkdir(d, exist_ok=True)
	os.makedirs(d, exist_ok=True)

I'd prefer the first one as makedirs calls os.path.exists() on all the parents of the path.

[skshetry]

Any reason why you did not go with the first option?

[sssilvar]

Less verbose, atomicity and clarity.

[skshetry]

Hi, thank you for contributing. The tests and the linter is failing, please take a look at https://dvc.org/doc/contributing/core on how to run tests and fix linter issues. Please feel free to ask if you need any help. :)

[sssilvar]

Thanks @skshetry for your feedback. Code's been updated. However somehow CI fails when running benchmars astral-sh/setup-uv@v3: https://github.com/iterative/dvc/actions/runs/11224357089/job/31200911385?pr=10580

Proposed a fix in 1e268fa

[skshetry]

LGTM although I am a bit concerned with performance issues with makedirs (stat calls can be expensive). But let's go with this one for now, we'll revisit if I find it to be the culprit.

Also, thank you for fixing the benchmarks workflow.