Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plots: log failures during datapoint conversions #9726

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

skshetry
Copy link
Member

Fixes #9441.

Note that we do merge props, and use that for all revision. So you may see a warning for each revisions.

Example output:

$ dvc plots diff
WARNING: In 'workspace', could not find provided field ('accss') in data fields ('step, acc').                                                                                                                       
WARNING: In 'HEAD', could not find provided field ('accss') in data fields ('step, acc').
file:///home/saugat/projects/iterative/vscode-dvc-demo/dvc_plots/index.html

Fixes iterative#9441.

Note that we do merge props, and use that for all revision. So you may
see warning for multiple revisions.
@skshetry skshetry added bugfix fixes bug A: plots Related to the plots labels Jul 12, 2023
@skshetry skshetry requested a review from dberenbaum July 12, 2023 07:17
@skshetry skshetry self-assigned this Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a5dda1b) 90.46% compared to head (4775ca9) 90.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9726   +/-   ##
=======================================
  Coverage   90.46%   90.46%           
=======================================
  Files         480      480           
  Lines       36468    36471    +3     
  Branches     5243     5243           
=======================================
+ Hits        32991    32994    +3     
  Misses       2885     2885           
  Partials      592      592           
Impacted Files Coverage Δ
dvc/render/match.py 98.82% <100.00%> (+0.04%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skshetry skshetry merged commit 4c8f539 into iterative:main Jul 12, 2023
20 checks passed
@skshetry skshetry deleted the log-plots branch July 12, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: plots Related to the plots bugfix fixes bug
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

plots: fail silently on errors
2 participants