Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dvc: don't use realpath where not needed #9780

Merged
merged 1 commit into from
Jul 29, 2023
Merged

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Jul 28, 2023

On windows it will get resolved to a UNC path, which is very error prone.

We've been misusing realpath in some repo-related places that triggered the need to use it in other places.

@efiop efiop added the P: windows Related to the Platform: Windows label Jul 28, 2023
@efiop efiop force-pushed the realpath branch 4 times, most recently from 32fa1ea to a133991 Compare July 29, 2023 21:07
@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ca0ad23) 90.46% compared to head (d9dfe26) 90.46%.

❗ Current head d9dfe26 differs from pull request most recent head 967d49a. Consider uploading reports for the commit 967d49a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9780   +/-   ##
=======================================
  Coverage   90.46%   90.46%           
=======================================
  Files         480      480           
  Lines       36602    36615   +13     
  Branches     5272     5277    +5     
=======================================
+ Hits        33112    33125   +13     
  Misses       2892     2892           
  Partials      598      598           
Files Changed Coverage Δ
dvc/utils/__init__.py 68.88% <ø> (ø)
dvc/config.py 96.29% <100.00%> (ø)
dvc/exceptions.py 93.91% <100.00%> (+0.08%) ⬆️
dvc/repo/__init__.py 94.50% <100.00%> (ø)
dvc/repo/experiments/executor/base.py 80.56% <100.00%> (ø)
dvc/repo/graph.py 92.59% <100.00%> (+0.38%) ⬆️
dvc/repo/init.py 93.87% <100.00%> (ø)
dvc/repo/stage.py 94.44% <100.00%> (+0.12%) ⬆️
dvc/stage/utils.py 92.64% <100.00%> (ø)
tests/func/test_stage.py 100.00% <100.00%> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efiop efiop marked this pull request as ready for review July 29, 2023 23:23
@efiop efiop merged commit 225814f into iterative:main Jul 29, 2023
20 checks passed
@efiop efiop self-assigned this Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P: windows Related to the Platform: Windows
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant