completion: fix broken completion generation for zsh #9797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #9797 +/- ##
==========================================
- Coverage 90.42% 90.19% -0.23%
==========================================
Files 480 482 +2
Lines 36670 36719 +49
Branches 5291 5299 +8
==========================================
- Hits 33158 33119 -39
- Misses 2906 2972 +66
- Partials 606 628 +22
☔ View full report in Codecov by Sentry. |
daavoo
approved these changes
Aug 3, 2023
daavoo
reviewed
Aug 3, 2023
|
gonna try out this patch in Homebrew/homebrew-core#138416 |
`dvc commit --help` was also completely broken, which is also fixed. This adds unit tests for completion generation for both zsh/bash, and tests that --help works for all commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dvc commit --helpwas also completely broken, which is also fixed.This adds unit tests for completion generation for both zsh/bash, and tests that --help works for all commands.
Closes #9796.