Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky test for repro --keep-going and --ignore #9802

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Aug 4, 2023

Closes #9798.

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.26% ⚠️

Comparison is base (b9b9f91) 90.41% compared to head (5c10b8d) 90.16%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9802      +/-   ##
==========================================
- Coverage   90.41%   90.16%   -0.26%     
==========================================
  Files         480      480              
  Lines       36656    36670      +14     
  Branches     5285     5291       +6     
==========================================
- Hits        33144    33064      -80     
- Misses       2906     2978      +72     
- Partials      606      628      +22     
Files Changed Coverage Δ
tests/func/repro/test_repro.py 100.00% <100.00%> (ø)

... and 28 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efiop
Copy link
Contributor

efiop commented Aug 4, 2023

@skshetry Thanks for a quick fix! 🙏

@efiop efiop merged commit 4067a86 into iterative:main Aug 4, 2023
18 checks passed
@skshetry skshetry deleted the fix-9798 branch August 4, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests: repro: flaky test_repro_keep_going
2 participants