config: resolve: handle ~ home dir #9825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
commented
Aug 9, 2023
Comment on lines
+269
to
+276
| conf_dir = os.path.abspath(os.path.dirname(filename)) | ||
| resolve = partial(cls._resolve, conf_dir) |
There was a problem hiding this comment.
Adjusted it to look like _save_paths below, and have the same structure here and in tests.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #9825 +/- ##
==========================================
- Coverage 90.42% 90.40% -0.02%
==========================================
Files 484 484
Lines 36887 36913 +26
Branches 5326 5332 +6
==========================================
+ Hits 33354 33371 +17
- Misses 2924 2930 +6
- Partials 609 612 +3
☔ View full report in Codecov by Sentry. |
efiop
force-pushed
the
fix-9822
branch
2 times, most recently
from
f47eec3
to
b73dced
Compare
efiop
changed the title
efiop
force-pushed
the
fix-9822
branch
4 times, most recently
from
5f7d2db
to
07f3f83
Compare
efiop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9822