Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema for matrix #41

Merged
merged 2 commits into from
Aug 18, 2023
Merged

schema for matrix #41

merged 2 commits into from
Aug 18, 2023

Conversation

skshetry
Copy link
Member

@dberenbaum
Copy link
Contributor

Why is it an entirely new class/type of Stage instead of adding a matrix attribute to the existing Stage (similar to cmd, deps, etc.)?

@skshetry
Copy link
Member Author

skshetry commented Aug 18, 2023

Semantically, Stage definition is not the same as a Matrix, it is a superset.

stages:
  stage1:
    matrix:
      ...

    <...Stage>

Also take foreach for example. The do part is a Stage definition which does not support matrix. Again, it's an internal code organization thing, which does not have any impact to users, they care about the Definition.

Definition = ForeachDo | Matrix | Stage

Copy link
Contributor

@daavoo daavoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for completeness, it might be good adding items to examples/invalid, i.e. mixing foreach and matrix

@skshetry skshetry merged commit 30a80f0 into master Aug 18, 2023
2 checks passed
@skshetry skshetry deleted the matrix branch August 18, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants