Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment of example-get-started-experiments model #222

Closed
dberenbaum opened this issue Jul 12, 2023 · 2 comments
Closed

Add deployment of example-get-started-experiments model #222

dberenbaum opened this issue Jul 12, 2023 · 2 comments
Assignees
Labels
A: example-get-started-experiments DVC Experiment, DVCLive examples priority-p1 Immediate pool of tickets to take and work as part of the next sprint

Comments

@dberenbaum
Copy link

Add a CI job that uses model registry to deploy the example-get-started-experiments model. Nice to have would be using Sagemaker for deployment.

@dberenbaum dberenbaum added the priority-p1 Immediate pool of tickets to take and work as part of the next sprint label Jul 12, 2023
@daavoo daavoo linked a pull request Jul 28, 2023 that will close this issue
2 tasks
@daavoo
Copy link
Contributor

daavoo commented Aug 1, 2023

Added a simple deployment pattern in #229 . It just creates a new endpoint whenever a new version is registered.

The stages in the registry are not handled at all, I preferred to discuss what would make sense to simulate a "real" use case.

A proposal I have is to use a pattern like the following:

  • MR: Registering version
    Sagemaker: Creates a model in Sagemaker but does not create an endpoint.

  • MR: Assigning stage.
    Sagemaker: Creates and links endpoint to the model created when registering a version.
    Depending on the stage, use a different endpoint config (i.e. larger instance type for prod, smaller for dev)

  • MR: Updating stage.

I think this should remove the endpoint from the previous stage and create a new one.

@daavoo daavoo added the A: example-get-started-experiments DVC Experiment, DVCLive examples label Aug 3, 2023
@dberenbaum
Copy link
Author

Fixed in #233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: example-get-started-experiments DVC Experiment, DVCLive examples priority-p1 Immediate pool of tickets to take and work as part of the next sprint
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants