Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear reference to a pull request in example-get-started-experiments README.md #230

Closed
tibor-mach opened this issue Aug 2, 2023 · 2 comments
Labels
A: example-get-started-experiments DVC Experiment, DVCLive examples bug Something isn't working

Comments

@tibor-mach
Copy link
Contributor

Here we have a reference in the README.md to a pull request which adds a model to the studio model registry. But there are no pull requests in that link, it just is just a link to the github pull requests page.

I am not sure if @aguschin meant that if you run the dvc-studio GH Actions workflow that you will get a pull request there or if it was supposed to actually refer to a specific pull request. Either way, I think this might be confusing to people who want to try things out.

I can update it to make it clearer, but please @aguschin let me know what the meaning was. I guess it was the first option, but I don't want to mess it up without asking. Thanks!

@dberenbaum
Copy link

There's discussion about it in #204, but it looks like it should have been dropped as part of #207. @tibor-mach Feel free to submit a PR to drop it.

@shcheklein shcheklein added A: example-get-started-experiments DVC Experiment, DVCLive examples bug Something isn't working labels Aug 2, 2023
@daavoo daavoo mentioned this issue Aug 3, 2023
2 tasks
@dberenbaum
Copy link

Fixed per #233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: example-get-started-experiments DVC Experiment, DVCLive examples bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants