Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stage from model name #236

Closed
wants to merge 1 commit into from
Closed

Remove stage from model name #236

wants to merge 1 commit into from

Conversation

tapadipti
Copy link
Contributor

As discussed here

@dberenbaum
Copy link

Hi @tapadipti, per the linked discussion, WDYT of dropping the version instead of the stage?

@tapadipti
Copy link
Contributor Author

@dberenbaum This is about creating one SageMaker model per version. This one should be per version, not per stage. So that when we deploy the same model version to different stages, SageMaker does not create separate models for them.

I'm not entirely sure if this change works, coz I haven't tried it. I made it based on what @daavoo said would work. I meant to request your (and @shcheklein's) review in a different PR. I added it to this PR by mistake.

What we need per stage is the endpoint, which @daavoo said he would update in the code.

@daavoo
Copy link
Contributor

daavoo commented Aug 21, 2023

I'm not entirely sure if this change works, coz I haven't tried it. I made it based on what @daavoo said would work. I meant to request your (and @shcheklein's) review in a different PR. I added it to this PR by mistake.

The P.R. doesn't currently work as expected because the composed_name is used also for create_endpoint.
2 different names should be built from the inputs.
I will update in a different P.R.

@daavoo daavoo closed this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants