Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use default dvclive plots #282

Merged
merged 1 commit into from
Apr 19, 2024
Merged

use default dvclive plots #282

merged 1 commit into from
Apr 19, 2024

Conversation

dberenbaum
Copy link

@dberenbaum dberenbaum commented Apr 17, 2024

When going through https://dvc.org/doc/start/data-pipelines/metrics-parameters-plots, no plots are generated unless the user manually edits dvc.yaml because we set Live(dvcyaml=False) here:

with Live(EVAL_PATH, dvcyaml=False) as live:

We set custom plots in dvc.yaml, but dvc.yaml is not downloaded as part of the get started tutorial's code.zip, so no plots will show for users.

This PR drops dvcyaml=False in code.zip, so that following the tutorial starts with the default dvclive plots. This PR also adds a step in generate.sh to edit the code to add dvcyaml=False and replace with the custom plots so we end up with the same nice-looking plots at the end. We can explain this as an optional step in the docs.

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dberenbaum !

@dberenbaum dberenbaum merged commit 3eb148c into master Apr 19, 2024
1 check passed
@dberenbaum dberenbaum deleted the dvclive-default-plots branch April 19, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants