Skip to content

Commit

Permalink
fix(chart-testing): Fix template used to generate the dockerconfig (#114
Browse files Browse the repository at this point in the history
)

Co-authored-by: Marcin Jasion <mjasion@users.noreply.github.com>
  • Loading branch information
mjasion and mjasion authored Jul 12, 2023
1 parent 06c1892 commit a308ee5
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,4 @@ jobs:
if: steps.list-changed.outputs.changed == 'true'
run: |
ct lint-and-install --target-branch ${{ github.event.repository.default_branch }} --upgrade --debug \
--helm-extra-set-args '--set ci=true --set global.blobvault.persistentVolume.storageClassName="standard" --set imagePullSecrets[0].name=iterativeai --set dockerUsername="${{ secrets.ITERATIVE_DOCKER_REGISTRY_USER }}" --set dockerPassword="${{ secrets.ITERATIVE_DOCKER_REGISTRY_PASSWORD }}" --set dockerServer=docker.iterative.ai'
--helm-extra-set-args '--set ci=true --set global.blobvault.persistentVolume.storageClassName="standard" --set imagePullSecrets[0].name=iterativeai --set dockerUsername=${{ secrets.ITERATIVE_DOCKER_REGISTRY_USER }} --set dockerPassword="${{ secrets.ITERATIVE_DOCKER_REGISTRY_PASSWORD }}" --set dockerServer=docker.iterative.ai'
2 changes: 1 addition & 1 deletion charts/studio/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.2.4
version: 0.2.5

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
2 changes: 1 addition & 1 deletion charts/studio/templates/ci-secret-docker-registry.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
{{- if (hasKey .Values "ci") }}
apiVersion: v1
data:
.dockerconfigjson: {{ include "dockerconfig" . | b64enc | quote }}
.dockerconfigjson: {{ include "ciDockerConfig" . | b64enc | quote }}
kind: Secret
metadata:
name: iterativeai
Expand Down
1 change: 0 additions & 1 deletion ct.yaml

This file was deleted.

0 comments on commit a308ee5

Please sign in to comment.