Rename ingress.protocol to ingress.scheme in _helpers.tpl

[0x2b3bfa0]

• https://github.com/iterative/studio/pull/7690#issuecomment-1725526566
  • https://github.com/iterative/studio/pull/7690#issuecomment-1727672427

helm-charts/charts/studio/templates/_helpers.tpl

Lines 194 to 196 in b643903

	{{- define "ingress.protocol" -}}
	http{{- if $.Values.global.ingress.tlsEnabled }}s{{- end}}
	{{- end }}

[0x2b3bfa0]

@mjasion, would it be possible to use relative paths for all the hardcoded URLs that use the template above? E.g.

helm-charts/charts/studio/templates/configmap-studio.yaml

Line 12 in b643903

API_URL: "{{include "ingress.protocol" . }}://{{.Values.global.host }}{{- if and .Values.global.basePath (not (eq .Values.global.basePath "/")) }}/{{ include "studio.basePath" . }}{{- end }}/api"

- {{include "ingress.protocol" . }}://{{.Values.global.host }}{{- if and .Values.global.basePath (not (eq .Values.global.basePath "/")) }}/{{ include "studio.basePath" . }}{{- end }}/api
+ /api

It's probably not viable for webhooks, but yes for API_URL and UI_URL among others.

• https://github.com/iterative/studio/pull/7690#issuecomment-1722998565

[mjasion]

@0x2b3bfa0 I think not now. We need to change the code of webapi and webui AFAIK.