feat(secrets): Allow passing secret environments outside Helm #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesper7
suggested changes
Jul 17, 2023
jesper7
approved these changes
Jul 18, 2023
Before all secret environments were defined in values.yaml. There were no way to set secret managed in external vault engine(AWS Secret Manager, Hashicorp Vault). This PR allow to load parameters from them.
Co-authored-by: Jesper Svendsen <99078145+jesper7@users.noreply.github.com>
mjasion
force-pushed
the
mount_external_secret
branch
from
0188d5a
to
8f89d0d
Compare
jesper7
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, all secret environments were defined in
values.yaml. There was no way to set secret managed in the external vault engine(AWS Secret Manager, Hashicorp Vault). This PR allow us to load parameters from them.