Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(secrets): Allow passing secret environments outside Helm #124

Merged
merged 2 commits into from
Jul 19, 2023
Merged

feat(secrets): Allow passing secret environments outside Helm #124

merged 2 commits into from
Jul 19, 2023

Commits on Jul 19, 2023

  1. feat(secrets): Allow passing secret environments outside release 

    Before all secret environments were defined in values.yaml. There were no way to set secret managed in external vault engine(AWS Secret Manager, Hashicorp Vault). This PR allow to load parameters from them.
    @mjasion
    mjasion committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    32e95c5 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Jesper Svendsen <99078145+jesper7@users.noreply.github.com>
    @mjasion @jesper7
    mjasion and jesper7 committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    8f89d0d View commit details
    Browse the repository at this point in the history