feat(blobvault): Make blobvault pvc storage optional if s3 bucket is used #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjasion
force-pushed
the
145-make-blobvault-pvc-storage-optional-if-s3-bucket-is-used
branch
from
1481e54
to
1014dad
Compare
1 task
mjasion
force-pushed
the
145-make-blobvault-pvc-storage-optional-if-s3-bucket-is-used
branch
from
39d44ba
to
3dcf452
Compare
mjasion
force-pushed
the
145-make-blobvault-pvc-storage-optional-if-s3-bucket-is-used
branch
3 times, most recently
from
c02af57
to
218370a
Compare
mjasion
force-pushed
the
145-make-blobvault-pvc-storage-optional-if-s3-bucket-is-used
branch
5 times, most recently
from
c0eac4b
to
38ac4f3
Compare
mjasion
force-pushed
the
145-make-blobvault-pvc-storage-optional-if-s3-bucket-is-used
branch
from
38ac4f3
to
6532e37
Compare
jesper7
reviewed
Aug 25, 2023
jesper7
suggested changes
Aug 28, 2023
charts/studio/templates/configmap-studio-backend-nginx-sidecar.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Jesper Svendsen <99078145+jesper7@users.noreply.github.com>
mjasion
force-pushed
the
145-make-blobvault-pvc-storage-optional-if-s3-bucket-is-used
branch
from
b47fd1b
to
f837af6
Compare
|
I've done a lot of manual testing, and one thing I noticed is that if you upgrade from an existing installation, plots won't load:
This needs further investigation |
Leaved only configmap
This 0.60.0 fixes the issue with Ingress objects not being cleaned up. To upgrade to 0.60.0 and above, you need to manually delete the Ingress object before upgrading: ```bash kubectl delete ingress -l app.kubernetes.io/managed-by=Helm --namespace studio kubectl delete ingress blobvault --namespace studio ```
mjasion
force-pushed
the
145-make-blobvault-pvc-storage-optional-if-s3-bucket-is-used
branch
from
9460e2a
to
0855e27
Compare
|
@jesper7 PTAL again :-) In ☝️ commits I
|
jesper7
suggested changes
Sep 5, 2023
mjasion
commented
Sep 5, 2023
Co-authored-by: Jesper Svendsen <99078145+jesper7@users.noreply.github.com>
jesper7
approved these changes
Sep 6, 2023
jesper7
deleted the
145-make-blobvault-pvc-storage-optional-if-s3-bucket-is-used
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change
This 0.60.0 fixes the issue with Ingress objects not being cleaned up.
To upgrade to 0.60.0 and above, you need to manually delete the Ingress object before upgrading:
Purpose of the PR
This PR configures the
blobvaultservice, which runs on the same node as the worker if there is no S3 bucket configured.Also, it replaces
nginxchart dependency for hosting Studio under the custombasePath. The nginx is deployed as a sidecar.Closes #145
Tasks