Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(skaffold): Add Skaffold #150

Merged
merged 4 commits into from
Aug 9, 2023
Merged

feat(skaffold): Add Skaffold #150

merged 4 commits into from
Aug 9, 2023

Conversation

mjasion
Copy link
Contributor

@mjasion mjasion commented Aug 3, 2023

Add Skaffold configuration for developing helm-chart. It auto deploys the Studio which allows for coninous testing of the development

Also introduces the CONTRIBUTING.md file, which provides instruction about running it.

@mjasion mjasion requested a review from 0x2b3bfa0 August 3, 2023 14:06
Copy link
Contributor

@jesper7 jesper7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice!
Just a small request: Let's change the order of the Kind and Skaffold steps in CONTRIBUTING.md. We need to explain Kind installation first, then Skaffold.

Also, please add a PR description.

Also introduce the CONTRIBUTING.md file, which provides instruction about running it.
Copy link
Contributor

@jesper7 jesper7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments about wording/grammar

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
mjasion and others added 3 commits August 8, 2023 14:26
Co-authored-by: Jesper Svendsen <99078145+jesper7@users.noreply.github.com>
Co-authored-by: Jesper Svendsen <99078145+jesper7@users.noreply.github.com>
@mjasion mjasion requested a review from jesper7 August 9, 2023 09:38
@mjasion mjasion added this pull request to the merge queue Aug 9, 2023
Merged via the queue into main with commit 3d59ad4 Aug 9, 2023
4 checks passed
@mjasion mjasion deleted the add_skaffold branch August 9, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants