Add support for self-hosted ClickHouse #413
Conversation
What do you mean exactly by "bring[ing] the whole chart"? If you mean "vendoring" (committing) any |
|
I primarily mean the tgz bundle that we provide, not necessarily vendoring code itself. I'm not sure how exactly that is done. |
|
We don't have to bundle (vendor) third-party charts with ours; Helm fetches them automatically. |
|
Q: does it come with some basic PV / PVC? |
| @@ -59,7 +59,7 @@ jobs: | |||
| if: steps.list-changed.outputs.changed == 'true' | |||
| run: | | |||
| ct lint-and-install --target-branch ${{ github.event.repository.default_branch }} --upgrade --skip-missing-values --debug \ | |||
| --helm-extra-set-args '--set ci=true --set global.blobvault.persistentVolume.storageClassName="standard" --set imagePullSecrets[0].name=iterativeai --set dockerUsername=${{ vars.ITERATIVE_DOCKER_REGISTRY_USER }} --set dockerPassword=${{ secrets.ITERATIVE_DOCKER_REGISTRY_PASSWORD }} --set dockerServer=docker.iterative.ai' | |||
| --helm-extra-set-args '--set ci=true --set global.blobvault.persistentVolume.storageClassName="standard" --set clickhouse.auth.password="clickhouse" --set imagePullSecrets[0].name=iterativeai --set dockerUsername=${{ vars.ITERATIVE_DOCKER_REGISTRY_USER }} --set dockerPassword=${{ secrets.ITERATIVE_DOCKER_REGISTRY_PASSWORD }} --set dockerServer=docker.iterative.ai' | |||
There was a problem hiding this comment.
https://github.com/iterative/helm-charts/actions/runs/9332063406/job/25690736127#step:10:117
Error: UPGRADE FAILED: execution error at (studio/charts/clickhouse/templates/secret.yaml:19:21):
PASSWORDS ERROR: You must provide your current passwords when upgrading the release.
Note that even after reinstallation, old credentials may be needed as they may be kept in persistent volume claims.
Further information can be obtained at https://docs.bitnami.com/general/how-to/troubleshoot-helm-chart-issues/#credential-errors-while-upgrading-chart-releases
'auth.password' must not be empty, please add '--set auth.***' to the command. To get the current value:
export ADMIN_PASSWORD=$(kubectl get secret --namespace "studio-woa6hxx2un" studio-woa6hxx2un-clickhouse -o jsonpath="{.data.admin-password}" | base64 -d)
There was a problem hiding this comment.
@iterative/platform, is there any better solution?
Yes, you can configure it with these options if needed. |
|
@0x2b3bfa0 are there any blockers? are we good to go here? |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
| # Shards / replicas configuration | ||
| replicaCount: 1 | ||
| shards: 1 |
There was a problem hiding this comment.
Using more shards/replicas will cause eventual consistency issues with table creation; to be fixed whenever we have to scale.
Important
Make sure that
global.dvcx.clickHouse.dsnis not set, or it will override the self-hosted ClickHouse connection string.