Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a sensible value for localStorage.size #435

Merged
merged 9 commits into from
Jul 4, 2024
Merged

Conversation

0x2b3bfa0
Copy link
Member

It's problematic on self-hosted deployments, especially with the 1Gi default size; let's keep it for people who need it and know what they're doing?

Alternatively, perhaps increase size to 20Gi as well?

@shcheklein
Copy link
Member

what is it used for in our cluster? if we don't have a local storage, what kind of storage is it using instead?

@mjasion
Copy link
Contributor

mjasion commented Jul 3, 2024

@shcheklein The node storage. Node allows to allocate storage until it will node storage will not be lower that 10% of the total disk space or 10GB(whichever is smaller)

@mjasion
Copy link
Contributor

mjasion commented Jul 3, 2024

@0x2b3bfa0 I would disable it for studio-worker as well

@shcheklein
Copy link
Member

so, what was the localStorage used for ? why is it needed at all? (can we clarify this in helm comments / docs)?

@0x2b3bfa0
Copy link
Member Author

localStorage is needed for dependency (virtual environment) caching; I'll just bump the default value to 50Gi mirroring our production deployment; it's the easiest.

@0x2b3bfa0 0x2b3bfa0 changed the title Disable localStorage by default Set a sensible value for localStorage.size Jul 4, 2024
@0x2b3bfa0
Copy link
Member Author

@shcheklein / @mjasion, better now?

@shcheklein
Copy link
Member

@shcheklein / @mjasion, better now?

  • there is still no explanation for what it is used for
  • is it a permanent storage (survives pod restarts / redeployments)?
  • if we disable it - where does it store those env then? what kind of other storages do we have on pods?

@0x2b3bfa0
Copy link
Member Author

0x2b3bfa0 commented Jul 4, 2024

there is still no explanation for what it is used for

is it a permanent storage (survives pod restarts / redeployments)?

Not by default; it'll be ephemeral.

if we disable it - where does it store those env then? what kind of other storages do we have on pods?

It would use the default /tmp (with no guarantees on free space availability; not a good idea)

@shcheklein
Copy link
Member

#435 (comment)

I mean the docs / or helm comments. We assume that help is used by customers, right? We should try to put some explanations if possible (not sure if we do this atm, but we were getting negative feedback about this recently).

But even for me, deploying this- It's hard to understand the purpose, if I need this or not, etc.

It would use the default /tmp (with no guarantees on free space availability; not a good idea)

okay, so, space guarantee is the only thing here? (just to make sure)

@0x2b3bfa0
Copy link
Member Author

okay, so, space guarantee is the only thing here? (just to make sure)

Yes, basically it guarantees /tmp/local has enough free space, is writable and so on (i.e. is usable)

@0x2b3bfa0
Copy link
Member Author

I mean the docs / or helm comments. We assume that help is used by customers, right? We should try to put some explanations if possible (not sure if we do this atm, but we were getting negative feedback about this recently).

Right; let me try to fix it.

But even for me, deploying this- It's hard to understand the purpose, if I need this or not, etc.

Long story short, it's needed to initialize & store virtual environments.

@0x2b3bfa0
Copy link
Member Author

Happier?

# -- Local storage configuration (used for storing DataChain virtual environments)

@shcheklein
Copy link
Member

Happier?

Well :) nobody outside would understand this ... even internal users - some people will not be able to connect the dots. Anyways, that's fine considering that we don't have much of the docs for the rest of the Helm anyways. It should be a separate issue / epic if we can get to it at some point.

Not a blocker, @0x2b3bfa0 . Thanks for taking care of this.

@0x2b3bfa0 0x2b3bfa0 merged commit ec4d7b1 into main Jul 4, 2024
4 checks passed
@0x2b3bfa0 0x2b3bfa0 deleted the 0x2b3bfa0-patch-1 branch July 4, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants