Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coherence in units for Model LOADPQ from PSAT folder #80

Closed
AIAitesla opened this issue Jan 15, 2016 · 2 comments
Closed

Coherence in units for Model LOADPQ from PSAT folder #80

AIAitesla opened this issue Jan 15, 2016 · 2 comments

Comments

@AIAitesla
Copy link
Contributor

@tinrabuzin

We are using model LOADPQ from PSAT package in Loads and this model extent to BaseClasses.baseLoad and iPSL.Electrical.Essentials.pfComponent where the angle is defined in radians (in baseLoad) and in degrees (in pfComponent) respectively.

Even if this does not seem to affect directly LOADPQ, it could affect other models depending on baselLoad, so it would be wise to check and correct this.

@MaximeBaudette
Copy link
Member

@AIAitesla
I marked this issue as duplicate in reference to #52.
I initiated the conversation so we can all agree on a set of units to use for parameters / variables. If we come to an agreement this can then be implemented everywhere in the same manner.

If you don't object, I will close this issue

@AIAitesla
Copy link
Contributor Author

We agree with you @MaximeBaudette. It is a good idea to implement it everywhere in the same manner.
Feel free to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants