Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PyTorch][CPP] Added inference_pytorch_cpp.py #422

Merged
merged 9 commits into from
Nov 9, 2023
Merged

[PyTorch][CPP] Added inference_pytorch_cpp.py #422

merged 9 commits into from
Nov 9, 2023

Conversation

a-sidorova
Copy link
Contributor

@a-sidorova a-sidorova commented Oct 19, 2023 •
edited
Loading

Details:

  • Added dump output for PyTorch launcher
  • Added python wrapper for CPP PyTorch launcher inference_pytorch_cpp.py

TODO:

  • Added model serialization since CPP launcher supports only files
  • Added validation results

@a-sidorova a-sidorova changed the title [PyTorch][CPP] Addedinference_pytorch_cpp.py [PyTorch][CPP] Added inference_pytorch_cpp.py Oct 19, 2023
@a-sidorova a-sidorova force-pushed the feature/pytorch/cpp_validation branch 3 times, most recently from 576821c to d30a301 Compare October 22, 2023 19:41
@a-sidorova a-sidorova marked this pull request as ready for review October 22, 2023 19:50
@a-sidorova
Copy link
Contributor Author

@FenixFly @valentina-kustikova взгляните, пожалуйста.

@a-sidorova a-sidorova requested a review from FenixFly October 22, 2023 19:57
valentina-kustikova
valentina-kustikova reviewed Oct 23, 2023
View reviewed changes
Copy link
Contributor

@valentina-kustikova valentina-kustikova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Обновить ридми в директории inference + необходимо понять, почему есть отличия в перечне классов, получаемых на выходе C++ и Python API.

@ismukhin
Copy link
Contributor

Обновить ридми в директории inference + необходимо понять, почему есть отличия в перечне классов, получаемых на выходе C++ и Python API.

Возможно дело в этом (#399 (comment))
Видимо, нужно убрать копирование изображений во временную директорию

@a-sidorova
Copy link
Contributor Author

@ismukhin вернула оригинальные изображения - помогло. Спасибо!

@valentina-kustikova теперь top-5 совпадает для C++ и Python API. Обновила README.
Попыталась отребейзиться на мастер, сломалась валидация вывода для Python API. Поэтому пока не пушу ребейз.

@a-sidorova a-sidorova force-pushed the feature/pytorch/cpp_validation branch from 2d69f67 to b1c5998 Compare October 30, 2023 14:47
@a-sidorova
Copy link
Contributor Author

@FenixFly @valentina-kustikova взгляните еще раз, пожалуйста. Комментарии поправила, отребейзилась.

valentina-kustikova
valentina-kustikova reviewed Oct 30, 2023
View reviewed changes
src/inference/README.md Show resolved Hide resolved
src/inference/README.md Outdated Show resolved Hide resolved
src/inference/README.md Outdated Show resolved Hide resolved
@valentina-kustikova
Copy link
Contributor

@FenixFly, глянь, пожалуйста.

@valentina-kustikova valentina-kustikova merged commit b2751ae into itlab-vision:master Nov 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentina-kustikova valentina-kustikova valentina-kustikova approved these changes

@maslovaz maslovaz maslovaz approved these changes

@FenixFly FenixFly FenixFly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@a-sidorova @ismukhin @valentina-kustikova @FenixFly @maslovaz