Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Starting field line is not computed for multiple flux surfaces #33

Open
krystophny opened this issue Sep 22, 2023 · 0 comments
Open

Starting field line is not computed for multiple flux surfaces #33

krystophny opened this issue Sep 22, 2023 · 0 comments
Assignees
@dannythecore
Labels
bug Something isn't working

Comments

@krystophny
Copy link
Member

Right now, init_starting_surf is only called as if there was only a single sbeg. The problem was masked, since integrate_mfl_can is defined outside a module, and it eats an array argument that was a scalar before without warning.

Solution: Do the computation of init_starting_surf to all flux surfaces inside sbeg array and change affected variables such as volstart to arrays.
@krystophny krystophny added the bug Something isn't working label Sep 22, 2023
@krystophny krystophny mentioned this issue Oct 19, 2023
Merged
krystophny added a commit that referenced this issue Oct 19, 2023
@krystophny
Refactor: add module alpha_lifetime_sub + fix (#35)
90b1fe6 
This fixes the problem quickly syntactically, but the logic still needs
to be updated in #33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dannythecore dannythecore

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krystophny @dannythecore