Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Postgres 17 #37

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Add support for Postgres 17 #37

merged 2 commits into from
Dec 10, 2024

Conversation

ivanlonel
Copy link
Owner

@ivanlonel ivanlonel commented Dec 10, 2024

Summary by Sourcery

Add support for Postgres 17 by updating Docker configurations, CI workflows, and documentation.

New Features:

  • Add support for Postgres 17 in the Docker setup.

CI:

  • Update CI workflow to include Postgres 17 in the testing matrix.

Documentation:

  • Update README to reflect the latest Postgres version as 17-3.5.

Copy link

sourcery-ai bot commented Dec 10, 2024

Reviewer's Guide by Sourcery

This PR updates the Docker image configuration to support PostgreSQL 17. The changes involve updating version references in the CI workflow, example compose file, and documentation to include PostgreSQL 17 as the latest supported version.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update CI workflow configuration to include PostgreSQL 17
  • Add PostgreSQL 17 to the test matrix
  • Update the LATEST_TAG environment variable from 16-3.5 to 17-3.5
.github/workflows/docker-publish.yml
Update example Docker Compose configuration
  • Update image tag reference from 16-3.5 to 17-3.5
  • Update BASE_IMAGE_TAG build argument from 16-3.5 to 17-3.5
compose_example/docker-compose.yml
Update documentation to reflect PostgreSQL 17 support
  • Update the latest tag reference from 16-3.5 to 17-3.5
README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ivanlonel - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a brief note in the PR description about testing results with Postgres 17 to confirm compatibility
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ivanlonel ivanlonel merged commit e4ea46d into master Dec 10, 2024
7 checks passed
@ivanlonel ivanlonel deleted the pg17 branch December 11, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant