Fix interpreter pgo defaulting on in tests incorrectly (dotnet#94295)

Lower severity level of a couple interpreter pgo log messages
ivanpovazan · Nov 2, 2023 · 2406107 · 2406107
1 parent 48f4d02
commit 2406107
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/mono/wasm/runtime/interp-pgo.ts b/src/mono/wasm/runtime/interp-pgo.ts
@@ -38,7 +38,7 @@ export async function interp_pgo_save_data () {
         // If save_table returned 0 despite not being passed a buffer, that means there is no
         //  table data to save, either because interp_pgo is disabled or no methods were tiered yet
         if (expectedSize <= 0) {
-            mono_log_error("Failed to save interp_pgo table (No data to save)");
+            mono_log_info("Failed to save interp_pgo table (No data to save)");
             return;
         }
 
@@ -64,7 +64,7 @@ export async function interp_pgo_save_data () {
 export async function interp_pgo_load_data () {
     const data = await getInterpPgoTable();
     if (!data) {
-        mono_log_error("Failed to load interp_pgo table (No table found in cache)");
+        mono_log_info("Failed to load interp_pgo table (No table found in cache)");
         return;
     }
 

diff --git a/src/mono/wasm/test-main.js b/src/mono/wasm/test-main.js
@@ -113,7 +113,7 @@ function initRunArgs(runArgs) {
     // default'ing to true for tests, unless debugging
     runArgs.forwardConsole = runArgs.forwardConsole === undefined ? !runArgs.debugging : runArgs.forwardConsole;
     runArgs.memorySnapshot = runArgs.memorySnapshot === undefined ? true : runArgs.memorySnapshot;
-    runArgs.interpreterPgo = runArgs.interpreterPgo === undefined ? true : runArgs.interpreterPgo;
+    runArgs.interpreterPgo = runArgs.interpreterPgo === undefined ? false : runArgs.interpreterPgo;
 
     return runArgs;
 }
@@ -147,6 +147,8 @@ function processArguments(incomingArguments, runArgs) {
             runArgs.forwardConsole = false;
         } else if (currentArg == "--no-memory-snapshot") {
             runArgs.memorySnapshot = false;
+        } else if (currentArg == "--interpreter-pgo") {
+            runArgs.interpreterPgo = true;
         } else if (currentArg == "--no-interpreter-pgo") {
             runArgs.interpreterPgo = false;
         } else if (currentArg.startsWith("--fetch-random-delay=")) {