Always send a SP after status code, even if no reason is given #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In section 4 of RFC 9112, we can see that the status line should adhere to this format:
Even if no
reason-phrase
is given, there should still be a SP (space) afterstatus-code
.edge-http
does not have this second SP, if reason is empty.Example (
|
marks begin and end of line):Valid status line:
|HTTP/1.1 101 |
Wrong status line (which is the current behavior):
|HTTP/1.1 101|
This is causing trouble for the python websockets library, because it want two
SP
s in the status line (which is valid according to the spec). See code hereThis can be reproduced by running the
ws_server
example on Linux machine, and runningpython3 -m websockets ws://<ip>:8881
: