Minor changes after Markus' 2.1 RFC review #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of these should preserve the text meaning. A few possibly controversial ones: * I'm now using the SQL 92 reference from ivoabib rather than a footnote * I'm saying "delimited identifier" at least in the section header on "Escape syntax"; I frankly would prefer if we spoke about delimited identifiers rather than escaping throughout -- both because there's no escaping here and because that's what SQL calls them --, but as long as the term appears at least once I won't quibble. * I'm lowercasing quite a few MAY-s that I really don't see as RFC-relevant. * I'm changing the float placements; for the small tables in the second half, I'm requiring h[ere] placement, as that's what the text needs (not there's inlinetable in ivoatex for that kind of thing). For the huge function tables, I'm loosening things up a bit, and I'm removing the float flusher. If you *really* want the floats to appear earlier, just pull them up lexcially in the source. But the large empty pages with these tables are not pretty (cf. also my RFC review).
gmantele
requested changes
Jul 25, 2023
ADQL.tex
Outdated
| has been extended to support queries that are specific to astronomy. Similarly | ||
| The VO has a number of tabular data sets, and many of them are stored in relational | ||
| databases, making SQL a convenient means of access. A subset of the SQL grammar | ||
| has been extended to support queries that are specific to astronomy. Similarl |
There was a problem hiding this comment.
Similarl does not seem correct. I assume you did not want to introduce a new typo :) Do we keep Similarly or did you want to replace it with Similar?
gmantele
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these should preserve the text meaning. A few possibly controversial ones:
I'm now using the SQL 92 reference from ivoabib rather than a footnote
I'm saying "delimited identifier" at least in the section header on "Escape syntax"; I frankly would prefer if we spoke about delimited identifiers rather than escaping throughout -- both because there's no escaping here and because that's what SQL calls them --, but as long as the term appears at least once I won't quibble.
I'm lowercasing quite a few MAY-s that I really don't see as RFC-relevant.
I'm changing the float placements; for the small tables in the second half, I'm requiring h[ere] placement, as that's what the text needs (not there's inlinetable in ivoatex for that kind of thing). For the huge function tables, I'm loosening things up a bit, and I'm removing the float flusher. If you really want the floats to appear earlier, just pull them up lexcially in the source. But the large empty pages with these tables are not pretty (cf. also my RFC review).