fix: reset hint valid offset when hide combinator succeeds

j-mie6 · Feb 7, 2024 · 4f00266 · 4f00266
1 parent 7fb6bcc
commit 4f00266
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/Text/Gigaparsec/Errors/Combinator.hs b/src/Text/Gigaparsec/Errors/Combinator.hs
@@ -124,7 +124,10 @@ hide :: Parsec a -> Parsec a
 hide (Internal.Parsec p) =
   Internal.Parsec $ \st good bad ->
     let !origConsumed = Internal.consumed st
-        good' x st' = good x st' { Internal.hints = Internal.hints st } -- TODO: should this change valid offset?
+        good' x st' = good x st' {
+          Internal.hints = Internal.hints st,
+          Internal.hintsValidOffset = Internal.hintsValidOffset st
+        }
         bad' err st'
           | Internal.consumed st' /= origConsumed = bad err st'
           | otherwise = Internal.useHints bad (Internal.emptyErr st' 0) st'

diff --git a/test/Text/Gigaparsec/ErrorsTests.hs b/test/Text/Gigaparsec/ErrorsTests.hs
@@ -394,4 +394,10 @@ regressionTests = testGroup "thou shalt not regress"
           testParse (amend greeting <?> ["greeting"]) "hello world." @?=
             Failure (TestError (1, 1) (VanillaError (Just (Raw "h")) [Named "greeting"] [] 1))
       ]
+  , testGroup "hide should"
+      [ testCase "not revive dead hints" do
+          let p = optional digit <* char ']' <* hide (optional letter) <* eof
+          testParse p "]1" @?=
+            Failure (TestError (1, 2) (VanillaError (Just (Raw "1")) [EndOfInput] [] 1))
+      ]
   ]