Rpmcallback inst start stop #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-mracek
reviewed
Jun 12, 2019
| @@ -1005,7 +1006,7 @@ def _run_transaction(self, cb): | |||
| else: | |||
| if self._record_history(): | |||
| herrors = [ucd(x) for x in errors] | |||
| self.history.end(rpmdbv, 2, errors=herrors) | |||
| self.history.end(rpmdbv) | |||
There was a problem hiding this comment.
I believe here is a problem. First I would like to move self.history.end(rpmdbv) few lines bellow. Also I believe that in this case it is normal that some elements were not done.
else:
logger.critical(_("Transaction couldn't start:"))
for e in errors:
logger.critical(ucd(e[0])) # should this be 'to_unicoded'?
if self._record_history() and not self._ts.isTsFlagSet(rpm.RPMTRANS_FLAG_TEST):
self.history.end(rpmdbv)
msg = _("Could not run transaction.")
raise dnf.exceptions.Error(msg)
j-mracek
reviewed
Jun 12, 2019
| @@ -995,6 +995,7 @@ def _run_transaction(self, cb): | |||
|
|
|||
| errstring = _('Errors occurred during transaction.') | |||
| logger.debug(errstring) | |||
| self.history.end(rpmdbv) | |||
There was a problem hiding this comment.
It results that the transaction will ends twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.