-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for missing device type #463
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgtobi
force-pushed
the
add_device_types_test
branch
from
October 21, 2023 20:45
20647dc
to
f12df2e
Compare
cgtobi
added a commit
that referenced
this pull request
Nov 4, 2023
* chore(deps): bump actions/setup-python from 4.4.0 to 4.5.0 Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.4.0 to 4.5.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4.4.0...v4.5.0) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps): bump requests from 2.28.1 to 2.28.2 Bumps [requests](https://github.com/psf/requests) from 2.28.1 to 2.28.2. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.28.1...v2.28.2) --- updated-dependencies: - dependency-name: requests dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps-dev): bump pylint from 2.15.9 to 2.15.10 Bumps [pylint](https://github.com/PyCQA/pylint) from 2.15.9 to 2.15.10. - [Release notes](https://github.com/PyCQA/pylint/releases) - [Commits](pylint-dev/pylint@v2.15.9...v2.15.10) --- updated-dependencies: - dependency-name: pylint dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps-dev): bump pytest from 7.2.0 to 7.2.1 Bumps [pytest](https://github.com/pytest-dev/pytest) from 7.2.0 to 7.2.1. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@7.2.0...7.2.1) --- updated-dependencies: - dependency-name: pytest dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps-dev): bump tox from 4.1.2 to 4.2.8 Bumps [tox](https://github.com/tox-dev/tox) from 4.1.2 to 4.2.8. - [Release notes](https://github.com/tox-dev/tox/releases) - [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst) - [Commits](tox-dev/tox@4.1.2...4.2.8) --- updated-dependencies: - dependency-name: tox dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps-dev): Bump dependencies Signed-off-by: dependabot[bot] <support@github.com> * ci: Fix GH action to publish to pypi * [pre-commit.ci] pre-commit autoupdate updates: - [github.com/psf/black: 23.1.0 → 23.3.0](psf/black@23.1.0...23.3.0) - [github.com/pre-commit/mirrors-mypy: v1.0.1 → v1.2.0](pre-commit/mirrors-mypy@v1.0.1...v1.2.0) * chore(deps): Bump actions/setup-python from 4.5.0 to 4.6.0 Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.5.0 to 4.6.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4.5.0...v4.6.0) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * [pre-commit.ci] pre-commit autoupdate updates: - [github.com/asottile/pyupgrade: v3.3.1 → v3.4.0](asottile/pyupgrade@v3.3.1...v3.4.0) * chore(deps): Bump actions/setup-python from 4.6.0 to 4.6.1 Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.6.0 to 4.6.1. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4.6.0...v4.6.1) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * [pre-commit.ci] pre-commit autoupdate updates: - [github.com/asottile/pyupgrade: v3.4.0 → v3.8.0](asottile/pyupgrade@v3.4.0...v3.8.0) - [github.com/asottile/add-trailing-comma: v2.4.0 → v3.0.0](asottile/add-trailing-comma@v2.4.0...v3.0.0) - [github.com/asottile/yesqa: v1.4.0 → v1.5.0](asottile/yesqa@v1.4.0...v1.5.0) - [github.com/pre-commit/mirrors-mypy: v1.2.0 → v1.4.1](pre-commit/mirrors-mypy@v1.2.0...v1.4.1) - [github.com/asottile/setup-cfg-fmt: v2.2.0 → v2.4.0](asottile/setup-cfg-fmt@v2.2.0...v2.4.0) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add DeviceCategory for NACamDoorTag * [pre-commit.ci] pre-commit autoupdate updates: - [github.com/asottile/pyupgrade: v3.8.0 → v3.10.1](asottile/pyupgrade@v3.8.0...v3.10.1) - [github.com/asottile/add-trailing-comma: v3.0.0 → v3.0.1](asottile/add-trailing-comma@v3.0.0...v3.0.1) - [github.com/psf/black: 23.3.0 → 23.7.0](psf/black@23.3.0...23.7.0) - [github.com/pre-commit/mirrors-mypy: v1.4.1 → v1.5.0](pre-commit/mirrors-mypy@v1.4.1...v1.5.0) - [github.com/PyCQA/flake8: 6.0.0 → 6.1.0](PyCQA/flake8@6.0.0...6.1.0) * chore(deps): Bump actions/setup-python from 4.6.1 to 4.7.0 Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.6.1 to 4.7.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4.6.1...v4.7.0) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * add method to modify schedule temperatures * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix post api usage * use official API to modify schedule * remove print statement * remove git attributes * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * revert changes to thermostat * fix mypy errors * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Create CODE_OF_CONDUCT.md * Add Bticino MyHome Server 1 scopes Added scopes "read_mhs1" and "write_mhs1" for the management of Bticino MyHome Server 1 modules * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * wrap zones with list * [pre-commit.ci] pre-commit autoupdate updates: - [github.com/asottile/pyupgrade: v3.10.1 → v3.14.0](asottile/pyupgrade@v3.10.1...v3.14.0) - [github.com/asottile/add-trailing-comma: v3.0.1 → v3.1.0](asottile/add-trailing-comma@v3.0.1...v3.1.0) - [github.com/psf/black: 23.7.0 → 23.9.1](psf/black@23.7.0...23.9.1) - [github.com/pre-commit/mirrors-mypy: v1.5.0 → v1.5.1](pre-commit/mirrors-mypy@v1.5.0...v1.5.1) - [github.com/asottile/setup-cfg-fmt: v2.4.0 → v2.5.0](asottile/setup-cfg-fmt@v2.4.0...v2.5.0) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * chore(deps): Bump actions/checkout from 3 to 4 Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps): Bump actions/setup-python from 4.7.0 to 4.7.1 Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.7.0 to 4.7.1. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4.7.0...v4.7.1) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Add important message * Update README.md * Drop Python 3.8 support * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * drop python 3.9 support * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * chore(deps-dev): Update bleach requirement from ~=6.0 to ~=6.1 (#449) * chore(deps-dev): Update bleach requirement from ~=6.0 to ~=6.1 Updates the requirements on [bleach](https://github.com/mozilla/bleach) to permit the latest version. - [Changelog](https://github.com/mozilla/bleach/blob/main/CHANGES) - [Commits](mozilla/bleach@v6.0.0...v6.1.0) --- updated-dependencies: - dependency-name: bleach dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Add ruff * ruff auto-fix * Refactor * [pre-commit.ci] pre-commit autoupdate (#455) * feat: add missing mixins * fix: fix query parameters serialization * Add missing device classes and fallback * Create CODEOWNERS * Add NLPD - Drivia dry contact * fix missing modules (#458) Co-authored-by: Tobias Sauerwein <cgtobi@gmail.com> * chore: update changelog * replace flake8 with ruff in gh action (#459) * add _missing_ function to DeviceType class (#462) * add _missing_ function to DeviceType class --------- Co-authored-by: Tobias Sauerwein <cgtobi@users.noreply.github.com> * Add test for missing device type (#463) * Add support for Legrand garage door opener (NLJ) (#464) * Add support for Legrand garage door opener (NLJ) https://www.legrand.fr/pro/catalogue/module-pour-porte-de-garage-et-portail-pour-installation-connectee-with-netatmo * Add support for BTicino intelligent light (BNIL) * Update CHANGELOG.md * Update CHANGELOG.md --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Hugo Dupras (jabesq) <jabesq@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hugo Dupras <hugo.dupras@marss.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Roger Miret <rogerxaic@users.noreply.github.com> Co-authored-by: Philipp Wüthrich <philipp.wuethrich@swisscom.com> Co-authored-by: giogua <gioeleguardabassi@gmail.com> Co-authored-by: Nathanael Marchand <NatMarchand@users.noreply.github.com> Co-authored-by: Jean Labrousse <labrous2@gmail.com>
cgtobi
added a commit
that referenced
this pull request
Nov 4, 2023
* chore(deps): bump actions/setup-python from 4.4.0 to 4.5.0 Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.4.0 to 4.5.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4.4.0...v4.5.0) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps): bump requests from 2.28.1 to 2.28.2 Bumps [requests](https://github.com/psf/requests) from 2.28.1 to 2.28.2. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.28.1...v2.28.2) --- updated-dependencies: - dependency-name: requests dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps-dev): bump pylint from 2.15.9 to 2.15.10 Bumps [pylint](https://github.com/PyCQA/pylint) from 2.15.9 to 2.15.10. - [Release notes](https://github.com/PyCQA/pylint/releases) - [Commits](pylint-dev/pylint@v2.15.9...v2.15.10) --- updated-dependencies: - dependency-name: pylint dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps-dev): bump pytest from 7.2.0 to 7.2.1 Bumps [pytest](https://github.com/pytest-dev/pytest) from 7.2.0 to 7.2.1. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@7.2.0...7.2.1) --- updated-dependencies: - dependency-name: pytest dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps-dev): bump tox from 4.1.2 to 4.2.8 Bumps [tox](https://github.com/tox-dev/tox) from 4.1.2 to 4.2.8. - [Release notes](https://github.com/tox-dev/tox/releases) - [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst) - [Commits](tox-dev/tox@4.1.2...4.2.8) --- updated-dependencies: - dependency-name: tox dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps-dev): Bump dependencies Signed-off-by: dependabot[bot] <support@github.com> * ci: Fix GH action to publish to pypi * [pre-commit.ci] pre-commit autoupdate updates: - [github.com/psf/black: 23.1.0 → 23.3.0](psf/black@23.1.0...23.3.0) - [github.com/pre-commit/mirrors-mypy: v1.0.1 → v1.2.0](pre-commit/mirrors-mypy@v1.0.1...v1.2.0) * chore(deps): Bump actions/setup-python from 4.5.0 to 4.6.0 Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.5.0 to 4.6.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4.5.0...v4.6.0) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * [pre-commit.ci] pre-commit autoupdate updates: - [github.com/asottile/pyupgrade: v3.3.1 → v3.4.0](asottile/pyupgrade@v3.3.1...v3.4.0) * chore(deps): Bump actions/setup-python from 4.6.0 to 4.6.1 Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.6.0 to 4.6.1. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4.6.0...v4.6.1) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * [pre-commit.ci] pre-commit autoupdate updates: - [github.com/asottile/pyupgrade: v3.4.0 → v3.8.0](asottile/pyupgrade@v3.4.0...v3.8.0) - [github.com/asottile/add-trailing-comma: v2.4.0 → v3.0.0](asottile/add-trailing-comma@v2.4.0...v3.0.0) - [github.com/asottile/yesqa: v1.4.0 → v1.5.0](asottile/yesqa@v1.4.0...v1.5.0) - [github.com/pre-commit/mirrors-mypy: v1.2.0 → v1.4.1](pre-commit/mirrors-mypy@v1.2.0...v1.4.1) - [github.com/asottile/setup-cfg-fmt: v2.2.0 → v2.4.0](asottile/setup-cfg-fmt@v2.2.0...v2.4.0) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add DeviceCategory for NACamDoorTag * [pre-commit.ci] pre-commit autoupdate updates: - [github.com/asottile/pyupgrade: v3.8.0 → v3.10.1](asottile/pyupgrade@v3.8.0...v3.10.1) - [github.com/asottile/add-trailing-comma: v3.0.0 → v3.0.1](asottile/add-trailing-comma@v3.0.0...v3.0.1) - [github.com/psf/black: 23.3.0 → 23.7.0](psf/black@23.3.0...23.7.0) - [github.com/pre-commit/mirrors-mypy: v1.4.1 → v1.5.0](pre-commit/mirrors-mypy@v1.4.1...v1.5.0) - [github.com/PyCQA/flake8: 6.0.0 → 6.1.0](PyCQA/flake8@6.0.0...6.1.0) * chore(deps): Bump actions/setup-python from 4.6.1 to 4.7.0 Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.6.1 to 4.7.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4.6.1...v4.7.0) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * add method to modify schedule temperatures * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix post api usage * use official API to modify schedule * remove print statement * remove git attributes * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * revert changes to thermostat * fix mypy errors * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Create CODE_OF_CONDUCT.md * Add Bticino MyHome Server 1 scopes Added scopes "read_mhs1" and "write_mhs1" for the management of Bticino MyHome Server 1 modules * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * wrap zones with list * [pre-commit.ci] pre-commit autoupdate updates: - [github.com/asottile/pyupgrade: v3.10.1 → v3.14.0](asottile/pyupgrade@v3.10.1...v3.14.0) - [github.com/asottile/add-trailing-comma: v3.0.1 → v3.1.0](asottile/add-trailing-comma@v3.0.1...v3.1.0) - [github.com/psf/black: 23.7.0 → 23.9.1](psf/black@23.7.0...23.9.1) - [github.com/pre-commit/mirrors-mypy: v1.5.0 → v1.5.1](pre-commit/mirrors-mypy@v1.5.0...v1.5.1) - [github.com/asottile/setup-cfg-fmt: v2.4.0 → v2.5.0](asottile/setup-cfg-fmt@v2.4.0...v2.5.0) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * chore(deps): Bump actions/checkout from 3 to 4 Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps): Bump actions/setup-python from 4.7.0 to 4.7.1 Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.7.0 to 4.7.1. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4.7.0...v4.7.1) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Add important message * Update README.md * Drop Python 3.8 support * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * drop python 3.9 support * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * chore(deps-dev): Update bleach requirement from ~=6.0 to ~=6.1 (#449) * chore(deps-dev): Update bleach requirement from ~=6.0 to ~=6.1 Updates the requirements on [bleach](https://github.com/mozilla/bleach) to permit the latest version. - [Changelog](https://github.com/mozilla/bleach/blob/main/CHANGES) - [Commits](mozilla/bleach@v6.0.0...v6.1.0) --- updated-dependencies: - dependency-name: bleach dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Add ruff * ruff auto-fix * Refactor * [pre-commit.ci] pre-commit autoupdate (#455) * feat: add missing mixins * fix: fix query parameters serialization * Add missing device classes and fallback * Create CODEOWNERS * Add NLPD - Drivia dry contact * fix missing modules (#458) Co-authored-by: Tobias Sauerwein <cgtobi@gmail.com> * chore: update changelog * replace flake8 with ruff in gh action (#459) * add _missing_ function to DeviceType class (#462) * add _missing_ function to DeviceType class --------- Co-authored-by: Tobias Sauerwein <cgtobi@users.noreply.github.com> * Add test for missing device type (#463) * Add support for Legrand garage door opener (NLJ) (#464) * Add support for Legrand garage door opener (NLJ) https://www.legrand.fr/pro/catalogue/module-pour-porte-de-garage-et-portail-pour-installation-connectee-with-netatmo * Add support for BTicino intelligent light (BNIL) * Update CHANGELOG.md * Update CHANGELOG.md --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Hugo Dupras (jabesq) <jabesq@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hugo Dupras <hugo.dupras@marss.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Roger Miret <rogerxaic@users.noreply.github.com> Co-authored-by: Philipp Wüthrich <philipp.wuethrich@swisscom.com> Co-authored-by: giogua <gioeleguardabassi@gmail.com> Co-authored-by: Nathanael Marchand <NatMarchand@users.noreply.github.com> Co-authored-by: Jean Labrousse <labrous2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.