Add power data to NLPD entities #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: This pull request introduces an enhancement to the NLPD entities by adding power data capabilities. It involves updating the class inheritance to include a PowerMixin, which extends the functionality of the NLPD class to handle power-related data. The changelog has been updated to reflect this change.
General suggestions:
- Consider providing a more detailed description in the changelog to help users understand the nature of the power data added, how it integrates with existing features, and any potential impact on their current setup.
- Ensure that the integration of the PowerMixin with the NLPD class is seamless and that all new methods and properties provided by the PowerMixin are fully compatible and tested with the NLPD class.
- Review the broader impact of this change on the system, particularly in terms of interactions with other modules and the overall performance of the system.
Your trial expires on December 16, 2023. Please email tim@sourcery.ai to continue using Sourcery ✨
| @@ -15,7 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ### Changed | |||
|
|
|||
| - | |||
| - Add power data to NLPD entities | |||
There was a problem hiding this comment.
suggestion (llm): The changelog entry for adding power data to NLPD entities could be more descriptive. It would be beneficial to specify what kind of power data was added, how it affects the existing functionality, and any potential implications for the users.
cgtobi
added a commit
that referenced
this pull request
Dec 15, 2023
* cd: Run publish-to-test-pypi only on development branch * fix devcontainer (#468) * Add start and end times to room class (#469) * Remove deprecated code (#461) * Remove deprecated code * Remove old codeql config * Remove unused fixture * Minor clean up * Refactor async_post_request Signed-off-by: Tobias Sauerwein <cgtobi@gmail.com> --------- Signed-off-by: Tobias Sauerwein <cgtobi@gmail.com> * Split tests and clean up (#471) * split tests * clean up cruft * Fix NLPD to provide energy readings * Add BNLD - Bticino dimmable light * Update readme (#472) * Clean up somfy shutter * Add new bticino scope * update readme * chore(deps): Bump actions/setup-python from 4.7.1 to 5.0.0 (#474) Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.7.1 to 5.0.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4.7.1...v5.0.0) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add missing device type mapping for NIS (#476) * Add power data to NLPD entities (#477) * Clean up (#479) --------- Signed-off-by: Tobias Sauerwein <cgtobi@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Hugo Dupras <jabesq@gmail.com> Co-authored-by: deosrc <deosrc@g-de.co.uk> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
cgtobi
added a commit
that referenced
this pull request
Dec 20, 2023
* cd: Run publish-to-test-pypi only on development branch * fix devcontainer (#468) * Add start and end times to room class (#469) * Remove deprecated code (#461) * Remove deprecated code * Remove old codeql config * Remove unused fixture * Minor clean up * Refactor async_post_request Signed-off-by: Tobias Sauerwein <cgtobi@gmail.com> --------- Signed-off-by: Tobias Sauerwein <cgtobi@gmail.com> * Split tests and clean up (#471) * split tests * clean up cruft * Fix NLPD to provide energy readings * Add BNLD - Bticino dimmable light * Update readme (#472) * Clean up somfy shutter * Add new bticino scope * update readme * chore(deps): Bump actions/setup-python from 4.7.1 to 5.0.0 (#474) Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.7.1 to 5.0.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4.7.1...v5.0.0) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add missing device type mapping for NIS (#476) * Add power data to NLPD entities (#477) * Clean up (#479) * Update CHANGELOG.md * Fix nlfe (#480) * Add missing NLFE Legrand dimmer switch * clean up * Update changelog --------- Signed-off-by: Tobias Sauerwein <cgtobi@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Hugo Dupras <jabesq@gmail.com> Co-authored-by: deosrc <deosrc@g-de.co.uk> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: home-assistant/core#103794