Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose camera person status #502

Merged

Conversation

adriencog
Copy link
Contributor

@adriencog adriencog commented Jul 14, 2024

Add two properties to Person class: out_of_sight & last_seen that we retrieve from home status call

Summary by Sourcery

This pull request introduces new properties out_of_sight and last_seen to the Person class, allowing for tracking of a person's visibility status and last seen timestamp. It also includes updates to the Person class to support these properties and extends existing tests to cover the new functionality.

  • New Features:
    • Added out_of_sight and last_seen properties to the Person class to track visibility and last seen timestamp.
  • Enhancements:
    • Updated the Person class to include a new update method for refreshing person data.
  • Tests:
    • Extended test cases in test_camera.py to validate the new out_of_sight and last_seen properties.

Copy link

sourcery-ai bot commented Jul 14, 2024

Reviewer's Guide by Sourcery

This pull request introduces two new properties, out_of_sight and last_seen, to the Person class in the pyatmo library. These properties are retrieved from the home status call and are used to update the person's status. The changes include modifications to the Person class, updates to the Home class to handle the new properties, and corresponding test updates.

File-Level Changes

Files Changes
src/pyatmo/person.py
src/pyatmo/home.py
Added and updated properties out_of_sight and last_seen in the Person class and ensured they are updated in the Home class.
tests/test_camera.py Extended tests to validate the new out_of_sight and last_seen properties in the Person class.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @adriencog - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟡 Testing: 3 issues found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

src/pyatmo/person.py Show resolved Hide resolved
src/pyatmo/home.py Show resolved Hide resolved
tests/test_camera.py Show resolved Hide resolved
tests/test_camera.py Show resolved Hide resolved
tests/test_camera.py Show resolved Hide resolved
@adriencog adriencog force-pushed the feat/expose-camera-person-status branch from 22b8957 to 1760771 Compare July 20, 2024 16:03
@cgtobi cgtobi merged commit 3247837 into jabesq-org:development Aug 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants