Skip to content

Commit

Permalink
no secrets in shared actions
Browse files Browse the repository at this point in the history
  • Loading branch information
jabez007 committed Aug 23, 2024
1 parent 569ff6b commit 379d279
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/shared/docker/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ runs:
with:
registry: ghcr.io
username: ${{ github.actor }} # The name of the person or app that initiated the workflow. For example, octocat.
password: ${{ secrets.GITHUB_TOKEN }} # automatically provided by GitHub Actions, so you don't need to create it manually.
password: ${{ env.GITHUB_TOKEN }} # automatically provided by GitHub Actions, so you don't need to create it manually.

- name: Build and push Docker image
if: ${{ inputs.push }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ jobs:
build-args: |
AWS_REGION=${{ vars.AWS_REGION }}
EKS_CLUSTER=${{ vars.EKS_CLUSTER }}
#env:
#GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
4 changes: 2 additions & 2 deletions .github/workflows/build_and_push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,5 @@ jobs:
build-args: |
AWS_REGION=${{ vars.AWS_REGION }}
EKS_CLUSTER=${{ vars.EKS_CLUSTER }}
#env:
#GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

0 comments on commit 379d279

Please sign in to comment.