re work merging data structures together

.github/workflows/update-repos.yml

@@ -15,7 +15,6 @@ jobs:
     runs-on: ubuntu-latest
     permissions:
       contents: read
-      pages: read
 
     steps:
       - name: Checkout Repository

locals.tf

@@ -1,3 +1,29 @@
 locals {
   environments = ["Development", "UAT", "Production"]
+
+  ####
+  # create a list of objects
+  # [
+  #   {
+  #     repository: "repo1",
+  #     environment: "Development"
+  #   },
+  #   {
+  #     repository: "repo1",
+  #     environment: "UAT"
+  #   },
+  #   {
+  #     repository: "repo1",
+  #     environment: "Production"
+  #   }  
+  # ]
+  ####
+  repo_environments = flatten([
+    for repo in data.github_repositories.my_topics.names : [
+      for env in local.environments : {
+        repository = repo
+        environment = env
+      }
+    ]
+  ])
 }

main.tf

@@ -8,14 +8,12 @@ data "github_repositories" "my_topics" {
 }
 
 resource "github_repository_environment" "environments" {
-  for_each = {
-    for repo in data.github_repositories.my_topics : repo.name => [
-      for env in local.environments : {
-        repository  = repo.name
-        environment = env
-      }
-    ]
-  }
+  # local.repo_environments is a list of objects
+  # so we must project that into a map
+  # where each key is unique
+  for_each = toMap({
+    for env in local.repo_environments : "${env.repository} - ${env.environment}" => env
+  })
 
   repository = each.value.repository
   environment = each.value.environment