StrictNamedArgs #1941
Merged
StrictNamedArgs #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new type very similar to
pgx.NamedArgs, but to protect against typos and/or forgotten arguments, arguments are checked that all are used in query and no extra arguments are provided.Considering the parsing is in unexported types/functions, this cannot be easily implemented outside of
pgxwithout copying most of theNamedArgsSQL parsing logic.The original logic is extracted to
rewriteQuerywithisStrictflag to decide whether to do the original flow ofNamedArgsor do the extra checks.