Make the recover() handler always return a stack trace

jacksontj · Sep 28, 2018 · 928cb99 · 928cb99
1 parent 7bd25d6
commit 928cb99
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/logging/logging.go b/logging/logging.go
@@ -65,11 +65,8 @@ func NewApacheLoggingHandler(handler http.Handler, logHandlers ...LogRecordHandl
 func (h *ApacheLoggingHandler) runHandler(rw http.ResponseWriter, r *http.Request) (err error) {
 	defer func() {
 		if rec := recover(); rec != nil {
-			var ok bool
-			err, ok = rec.(error)
-			if !ok {
-				err = errors.Wrap(fmt.Errorf(string(debug.Stack())), "Error running handler")
-			}
+			// Just return a stack trace always
+			err = errors.Wrap(fmt.Errorf(string(debug.Stack())), "Error running handler")
 		}
 	}()
 	h.handler.ServeHTTP(rw, r)